Bug 2314454: refactor parseEndpoint to accept pod names with '.' in it #209
Conversation
|
@rewantsoni: This pull request references Bugzilla bug 2314454, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes allows us to create pod with '.' in between, we should not limit parsing such endpoints Signed-off-by: Rewant Soni <[email protected]> (cherry picked from commit b0ae317)
rewantsoni
force-pushed
the
r-endpoint
branch
from
6e4f7d4
to
854aef0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5cecc99
into
red-hat-storage:release-4.17
|
@rewantsoni: All pull requests linked via external trackers have merged: Bugzilla bug 2314454 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes allows us to create pod with '.' in between, we should not limit parsing such endpoints
(cherry picked from commit b0ae317)